[moin-review] 2021-11-10

Facts

• 국가 공통으로 사용하는 input 생성
• 특정 국가만 사용하는 input 생성

Findings

• UI component 를 사용해도 화면과 match 되는 컴포넌트로 분리하면 가독성을 높일 수 있다.

<Box>
      <BankSelectModal
        bank={bank}
        bankList={bankList}
        onChangeRecipientField={onChangeRecipientField}
      />
      <BankBranchSelectModal
        branch={branch}
        branchList={branchList}
        onChangeRecipientField={onChangeRecipientField}
      />
      <BankProvinceSelectModal
        bank_province={bank_province}
        provinceList={provinceList}
        onChangeRecipientField={onChangeRecipientField}
      />
      <BankCitySelectModal
        bank_city={bank_city}
        cityList={cityList}
        onChangeRecipientField={onChangeRecipientField}
      />
      <RecipientInput
        name='account'
        label='계좌번호'
        placeholder='Account No.'
        recipieitField={account}
        onChangeRecipientField={onChangeRecipientField}
      />
    </Box><Box>
      <BankSelectModal
        bank={bank}
        bankList={bankList}
        onChangeRecipientField={onChangeRecipientField}
      />
      <BankBranchSelectModal
        branch={branch}
        branchList={branchList}
        onChangeRecipientField={onChangeRecipientField}
      />
      <BankProvinceSelectModal
        bank_province={bank_province}
        provinceList={provinceList}
        onChangeRecipientField={onChangeRecipientField}
      />
      <BankCitySelectModal
        bank_city={bank_city}
        cityList={cityList}
        onChangeRecipientField={onChangeRecipientField}
      />
      <RecipientInput
        name='account'
        label='계좌번호'
        placeholder='Account No.'
        recipieitField={account}
        onChangeRecipientField={onChangeRecipientField}
      />
    </Box>

Feelings

• 디자인만 보고 공통사항을 먼저 뽑아내서 작업전에 반영할 수 있도록 해야겠다..