21.09.30. chromium issue_1252242 패치 도전2(fail 수정)

Nayeon Kim·2021년 9월 30일
2

chromium

목록 보기
8/10

크로미움 브라우저 테스트를 실행하기 위해 시간을 내서 chromium.orgs에서 제시하고 있는 테스트 관련 information 문서들을 다시 찬찬히 읽어보았다.
브라우저 테스트 항목이 약 14000개이기 때문에, 전부 다 돌리는 것은 시간과 메모리 낭비가 심하다. 그래서 filter를 추가해 필요한 부분들만 테스트 진행하는 것이 좋다.

해당 이슈의 경우, content_browsertests에 문제가 있는 듯 해서 gtest_filter를 끼워 넣고 다시 브라우저 테스트를 실행시켜 보았다.

first try- 14000개 중 관련 없는 테스트들의 경우, unknown이라 뜨면서 result를 제출하지 않고 그냥 넘어감. gtestfilter에 문자가 typo 나서 content_browsertests도 그냥 넘어가 버림. 실패

cd c:\chromium\src

c:\chromium\src>out\Default\browser_tests --gtest-filter = ContentBrowserTest

.
.
.
[1/14120] PlatformAppBrowserTest.RunningAppsAreRecorded (UNKNOWN)
[0930/173043.276:ERROR:test_launcher.cc(1132)] no test result for PlatformAppBrowserTest.FileAccessIsSavedToPrefs
.
.

second try-오타 고치니까 돌아가긴 돌아가는데, filter가 제대로 적용돼서 content_browsertests만 걸러내는 역할을 해내는지는 모르겠음. 일단 초반에 fail된 3개의 테스트 파일을 확인 중.
그냥 out\Default\browser_tests 했을 때랑 filter 추가했을 때랑 다른 점은 stacktrace 출력됨. 성공하면 passed, 실패하면 failed가 뜸

//성공시

c:\chromium\src>out\Default\browser_tests --gtest_filter = ContentBrowserTest
Note: Google Test filter = PlatformAppBrowserTest.RunningAppsAreRecorded
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from PlatformAppBrowserTest, where TypeParam =
[ RUN      ] PlatformAppBrowserTest.RunningAppsAreRecorded
[43240:46224:0930/205648.501:INFO:content_main_runner_impl.cc(1100)] Chrome is running in full browser mode.
[43240:25020:0930/205649.330:ERROR:chrome_browser_main_extra_parts_metrics.cc(230)] crbug.com/1216328: Checking Bluetooth availability started. Please report if there is no report that this ends.
[43240:25020:0930/205649.331:ERROR:chrome_browser_main_extra_parts_metrics.cc(233)] crbug.com/1216328: Checking Bluetooth availability ended.
[43240:25020:0930/205649.334:ERROR:chrome_browser_main_extra_parts_metrics.cc(236)] crbug.com/1216328: Checking default browser status started. Please report if there is no report that this ends.
[43240:25020:0930/205649.392:ERROR:chrome_browser_main_extra_parts_metrics.cc(240)] crbug.com/1216328: Checking default browser status ended.
[43240:46224:0930/205649.424:ERROR:device_event_log_impl.cc(214)] [20:56:49.424] USB: usb_device_handle_win.cc:1048 Failed to read descriptor from node connection: 시스템에 부착된 장치가 작동하지 않습니다. (0x1F)
[43240:46224:0930/205649.463:ERROR:device_event_log_impl.cc(214)] [20:56:49.463] USB: usb_device_handle_win.cc:1048 Failed to read descriptor from node connection: 시스템에 부착된 장치가 작동하지 않습니다. (0x1F)
[43240:46224:0930/205655.821:WARNING:pref_notifier_impl.cc(40)] Pref observer for media_router.cast_allow_all_ips found at shutdown.
[       OK ] PlatformAppBrowserTest.RunningAppsAreRecorded (7385 ms)
[----------] 1 test from PlatformAppBrowserTest (7387 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (7397 ms total)
[  PASSED  ] 1 test.

//실패시

Note: Google Test filter = ImageAnnotationBrowserTest.ImagesInLinks
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from ImageAnnotationBrowserTest, where TypeParam =
[ RUN      ] ImageAnnotationBrowserTest.ImagesInLinks
[33416:11544:0930/210308.670:INFO:content_main_runner_impl.cc(1100)] Chrome is running in full browser mode.
[33416:31352:0930/210309.715:ERROR:chrome_browser_main_extra_parts_metrics.cc(230)] crbug.com/1216328: Checking Bluetooth availability started. Please report if there is no report that this ends.
[33416:31352:0930/210309.720:ERROR:chrome_browser_main_extra_parts_metrics.cc(233)] crbug.com/1216328: Checking Bluetooth availability ended.
[33416:31352:0930/210309.722:ERROR:chrome_browser_main_extra_parts_metrics.cc(236)] crbug.com/1216328: Checking default browser status started. Please report if there is no report that this ends.
[33416:31352:0930/210309.836:ERROR:chrome_browser_main_extra_parts_metrics.cc(240)] crbug.com/1216328: Checking default browser status ended.
[33416:11544:0930/210309.852:ERROR:device_event_log_impl.cc(214)] [21:03:09.852] USB: usb_device_handle_win.cc:1048 Failed to read descriptor from node connection: 시스템에 부착된 장치가 작동하지 않습니다. (0x1F)
[33416:11544:0930/210309.859:ERROR:device_event_log_impl.cc(214)] [21:03:09.859] USB: usb_device_handle_win.cc:1048 Failed to read descriptor from node connection: 시스템에 부착된 장치가 작동하지 않습니다. (0x1F)
[33416:11544:0930/210312.380:INFO:ui_test_utils.cc(224)] NavigateToURL: https://127.0.0.1:3755/accessibility/image_annotation_link.html
[33416:11544:0930/210318.855:INFO:accessibility_notification_waiter.cc(156)] OnAccessibilityEvent kChildrenChanged
[33416:11544:0930/210318.855:INFO:accessibility_notification_waiter.cc(156)] OnAccessibilityEvent kChildrenChanged
[33416:11544:0930/210318.855:INFO:accessibility_notification_waiter.cc(156)] OnAccessibilityEvent kLayoutComplete
[33416:11544:0930/210318.855:INFO:accessibility_notification_waiter.cc(156)] OnAccessibilityEvent kLoadComplete
[33416:46888:0930/210318.859:WARNING:embedded_test_server.cc(667)] Request not handled. Returning 404: /favicon.ico
[33416:11544:0930/210319.011:INFO:accessibility_notification_waiter.cc(156)] OnAccessibilityEvent kNone
Still waiting for the following processes to finish:
        "out\Default\browser_tests" --disable-gpu-process-for-dx12-info-collection --gtest_also_run_disabled_tests --gtest_filter=ImageAnnotationBrowserTest.ImagesInLinks --single-process-tests --test-launcher-output="C:\Users\SAMSUNG\AppData\Local\Temp\19580_148869241\results19580_1324077768\test_results.xml" --test-launcher-retries-left=0 --user-data-dir="C:\Users\SAMSUNG\AppData\Local\Temp\19580_148869241\user_data"
Still waiting for the following processes to finish:
        "out\Default\browser_tests" --disable-gpu-process-for-dx12-info-collection --gtest_also_run_disabled_tests --gtest_filter=ImageAnnotationBrowserTest.ImagesInLinks --single-process-tests --test-launcher-output="C:\Users\SAMSUNG\AppData\Local\Temp\19580_148869241\results19580_1324077768\test_results.xml" --test-launcher-retries-left=0 --user-data-dir="C:\Users\SAMSUNG\AppData\Local\Temp\19580_148869241\user_data"
../../chrome/browser/accessibility/image_annotation_browsertest.cc(325): error: Value of: DescribeNodesWithAnnotations(ax_tree_update)
Expected: has 10 elements where
element #0 is equal to "image Appears to say: red.png Annotation",
element #1 is equal to "link Appears to say: green.png Annotation",
element #2 is equal to "image Appears to say: green.png Annotation",
element #3 is equal to "image Appears to say: red.png Annotation",
element #4 is equal to "image Appears to say: printer.png Annotation",
element #5 is equal to "image Appears to say: red.png Annotation",
element #6 is equal to "link Appears to say: printer.png Annotation",
element #7 is equal to "image Appears to say: printer.png Annotation",
element #8 is equal to "link Appears to say: green.png Annotation",
element #9 is equal to "image Appears to say: green.png Annotation"
  Actual: { "image \xED\x85\x8D\xEC\x8A\xA4\xED\x8A\xB8\xEA\xB0\x80 red.png Annotation\xEC\x9D\xB8 \xEA\xB2\x83\xEC\x9C\xBC\xEB\xA1\x9C \xEB\xB3\xB4\xEC\x9E\x85\xEB\x8B\x88\xEB\x8B\xA4"
    As Text: "image ?띿뒪?멸? red.png Annotation??寃껋쑝濡?蹂댁엯?덈떎", "link \xED\x85\x8D\xEC\x8A\xA4\xED\x8A\xB8\xEA\xB0\x80 green.png Annotation\xEC\x9D\xB8 \xEA\xB2\x83\xEC\x9C\xBC\xEB\xA1\x9C \xEB\xB3\xB4\xEC\x9E\x85\xEB\x8B\x88\xEB\x8B\xA4"
    As Text: "link ?띿뒪?멸? green.png Annotation??寃껋쑝濡?蹂댁엯?덈떎", "image \xED\x85\x8D\xEC\x8A\xA4\xED\x8A\xB8\xEA\xB0\x80 green.png Annotation\xEC\x9D\xB8 \xEA\xB2\x83\xEC\x9C\xBC\xEB\xA1\x9C \xEB\xB3\xB4\xEC\x9E\x85\xEB\x8B\x88\xEB\x8B\xA4"
    As Text: "image ?띿뒪?멸? green.png Annotation??寃껋쑝濡?蹂댁엯?덈떎", "image \xED\x85\x8D\xEC\x8A\xA4\xED\x8A\xB8\xEA\xB0\x80 red.png Annotation\xEC\x9D\xB8 \xEA\xB2\x83\xEC\x9C\xBC\xEB\xA1\x9C \xEB\xB3\xB4\xEC\x9E\x85\xEB\x8B\x88\xEB\x8B\xA4"
    As Text: "image ?띿뒪?멸? red.png Annotation??寃껋쑝濡?蹂댁엯?덈떎", "image \xED\x85\x8D\xEC\x8A\xA4\xED\x8A\xB8\xEA\xB0\x80 printer.png Annotation\xEC\x9D\xB8 \xEA\xB2\x83\xEC\x9C\xBC\xEB\xA1\x9C \xEB\xB3\xB4\xEC\x9E\x85\xEB\x8B\x88\xEB\x8B\xA4"
    As Text: "image ?띿뒪?멸? printer.png Annotation??寃껋쑝濡?蹂댁엯?덈떎", "image \xED\x85\x8D\xEC\x8A\xA4\xED\x8A\xB8\xEA\xB0\x80 red.png Annotation\xEC\x9D\xB8 \xEA\xB2\x83\xEC\x9C\xBC\xEB\xA1\x9C \xEB\xB3\xB4\xEC\x9E\x85\xEB\x8B\x88\xEB\x8B\xA4"
    As Text: "image ?띿뒪?멸? red.png Annotation??寃껋쑝濡?蹂댁엯?덈떎", "link \xED\x85\x8D\xEC\x8A\xA4\xED\x8A\xB8\xEA\xB0\x80 printer.png Annotation\xEC\x9D\xB8 \xEA\xB2\x83\xEC\x9C\xBC\xEB\xA1\x9C \xEB\xB3\xB4\xEC\x9E\x85\xEB\x8B\x88\xEB\x8B\xA4"
    As Text: "link ?띿뒪?멸? printer.png Annotation??寃껋쑝濡?蹂댁엯?덈떎", "image \xED\x85\x8D\xEC\x8A\xA4\xED\x8A\xB8\xEA\xB0\x80 printer.png Annotation\xEC\x9D\xB8 \xEA\xB2\x83\xEC\x9C\xBC\xEB\xA1\x9C \xEB\xB3\xB4\xEC\x9E\x85\xEB\x8B\x88\xEB\x8B\xA4"
    As Text: "image ?띿뒪?멸? printer.png Annotation??寃껋쑝濡?蹂댁엯?덈떎", "link \xED\x85\x8D\xEC\x8A\xA4\xED\x8A\xB8\xEA\xB0\x80 green.png Annotation\xEC\x9D\xB8 \xEA\xB2\x83\xEC\x9C\xBC\xEB\xA1\x9C \xEB\xB3\xB4\xEC\x9E\x85\xEB\x8B\x88\xEB\x8B\xA4"
    As Text: "link ?띿뒪?멸? green.png Annotation??寃껋쑝濡?蹂댁엯?덈떎", "image \xED\x85\x8D\xEC\x8A\xA4\xED\x8A\xB8\xEA\xB0\x80 green.png Annotation\xEC\x9D\xB8 \xEA\xB2\x83\xEC\x9C\xBC\xEB\xA1\x9C \xEB\xB3\xB4\xEC\x9E\x85\xEB\x8B\x88\xEB\x8B\xA4"
    As Text: "image ?띿뒪?멸? green.png Annotation??寃껋쑝濡?蹂댁엯?덈떎" }, whose element #0 doesn't match
Stack trace:
Backtrace:
        ImageAnnotationBrowserTest_ImagesInLinks_Test::RunTestOnMainThread [0x00007FF72F87EF1F+1039] (c:\chromium\src\chrome\browser\accessibility\image_annotation_browsertest.cc:314)
        content::BrowserTestBase::ProxyRunTestOnMainThreadLoop [0x00007FF738F62B42+1506] (c:\chromium\src\content\public\test\browser_test_base.cc:873)
        base::internal::FunctorTraits<void (content::BrowserTestBase::*)(),void>::Invoke<void (content::BrowserTestBase::*)(),content::BrowserTestBase *> [0x00007FF738F65F9A+26] (c:\chromium\src\base\bind_internal.h:509)
        base::internal::InvokeHelper<0,void>::MakeItSo<void (content::Br[33416:11544:0930/210348.264:WARNING:pref_notifier_impl.cc(40)] Pref observer for media_router.cast_allow_all_ips found at shutdown.
[  FAILED  ] ImageAnnotationBrowserTest.ImagesInLinks, where TypeParam =  and GetParam() =  (39707 ms)
[----------] 1 test from ImageAnnotationBrowserTest (39710 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (39719 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] ImageAnnotationBrowserTest.ImagesInLinks, where TypeParam =  and GetParam() =

 1 FAILED TEST

오늘은 일단 브라우저 테스트의 어느 부분이 fail나는지 일부 확인할 수 있었다.
하지만 이 다음에 또 어떻게 해야할지도 막막한데, 일단 리뷰어를 추가해 리뷰 받는 과정에서 모르는 부분 질문하면서 해결해보고자 한다.

profile
Department of Computer Science

0개의 댓글