21.09.07. chromium issue_1240767 패치 도전1(실패)

Nayeon Kim·2021년 9월 7일
1

chromium

목록 보기
3/10

일단, chromium bug로 올라온 issue_1240767은 다크 모드 상에서 측면 패널의 스크롤바 색상 변경이 적용되지 않는 것과 관련된다.

  1. 크롬 측면 패널(side panel) 기능을 켜고(구글 크롬에는 없는 것 같음)
  2. 컴퓨터 시스템이 dark mode로 설정돼있을 때, chrome://history나 chrome://bookmarks에서 확인할 수 있듯이 dark mode style의 스크롤바로 색상이 변경돼야 하는데
  3. 측면 패널은 dark mode 상에서도 light mode 상태의 스크롤바 style이 지속되고 있음을 볼 수 있다.

chrome://history 등의 페이지들도 이전에 이와 같은 버그가 있어서, issue_1142291에서 제시되어 meta 태그를 이용해 fixed되어 dark mode style 스크롤바가 적용될 수 있었던 것이다.

이를 통해 issue_1240767 또한 같은 방식으로 meta 태그를 추가해주면 해결이 될 줄 알았는데,
그리 간단하게 풀릴 문제가 아니었나보다.
거의 2주째 고민중..

c:\chromium>cd c:
c:\chromium

c:\chromium>cd c:\chromium\src

c:\chromium\src>out\Default\chrome

c:\chromium\src>git status
Refresh index: 100% (376709/376709), done.
HEAD detached at origin/main
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        modified:   build/vs_toolchain.py
        modified:   chrome/browser/resources/read_later/app.html
        modified:   chrome/browser/resources/read_later/read_later.html
        modified:   chrome/browser/resources/read_later/read_later_item.html
        modified:   chrome/browser/resources/read_later/side_panel/app.html

no changes added to commit (use "git add" and/or "git commit -a")

c:\chromium\src>git checkout -b scrollbar
Switched to a new branch 'scrollbar'

c:\chromium\src>git add chrome/browser/resources/read_later/app.html

c:\chromium\src>git add chrome/browser/resources/read_later/read_later.html

c:\chromium\src>git add chrome/browser/resources/read_later/read_later_item.html

c:\chromium\src>git add chrome/browser/resources/read_later/side_panel/app.html

c:\chromium\src>autoninja -C out/Default chrome
"C:\src\depot_tools\ninja.exe" -C out/Default chrome -j 10
ninja: Entering directory `out/Default'
[43/43] STAMP obj/chrome/chrome.stamp

c:\chromium\src>out\Default\chrome

c:\chromium\src>git checkout c:\chromium\src\chrome\browser\resources\read_later
Updated 0 paths from the index

c:\chromium\src>git reset scrollbar
Unstaged changes after reset:
M       build/vs_toolchain.py
M       chrome/browser/resources/read_later/app.html
M       chrome/browser/resources/read_later/read_later.html
M       chrome/browser/resources/read_later/read_later_item.html
M       chrome/browser/resources/read_later/side_panel/app.html

c:\chromium\src>git checkout .
Updated 5 paths from the index

c:\chromium\src>git status
On branch scrollbar
nothing to commit, working tree clean

c:\chromium\src>git clean -fdx
Removing .landmines
Removing build/__pycache__/
Removing build/android/gyp/util/__pycache__/
Removing build/config/gclient_args.gni
Removing build/toolchain/__pycache__/
Removing build/toolchain/win/rc/win/rc.exe
Removing build/util/LASTCHANGE
Removing build/util/LASTCHANGE.committime
Removing build/util/__pycache__/
Removing build/util/lib/__pycache__/
Removing build/util/lib/results/__pycache__/
Removing buildtools/win/.versions/
Removing buildtools/win/clang-format.exe
Removing buildtools/win/gn.exe
Removing components/resources/protobufs/__pycache__/
Removing components/variations/service/__pycache__/
Removing components/zucchini/fuzzers/testdata/new_eventlog_provider.dll
Removing components/zucchini/fuzzers/testdata/old_eventlog_provider.dll
Removing components/zucchini/testdata/chrome64_1.exe
Removing components/zucchini/testdata/chrome64_2.exe
Removing components/zucchini/testdata/setup1.exe
Removing components/zucchini/testdata/setup2.exe
Removing content/test/data/gpu/mediapipe/
Removing content/test/data/gpu/mediapipe_zip/mediapipe_chromium_tests.zip
Removing gpu/config/gpu_lists_version.h
Removing mojo/public/tools/bindings/generators/__pycache__/
Removing mojo/public/tools/mojom/mojom/__pycache__/
Removing mojo/public/tools/mojom/mojom/generate/__pycache__/
Removing mojo/public/tools/mojom/mojom/parse/__pycache__/
Removing out/
Removing ppapi/generators/__pycache__/
Removing skia/ext/skia_commit_hash.h
Removing testing/__pycache__/
Removing testing/location_tags.json
Removing testing/scripts/__pycache__/
Removing third_party/apache-win32/bin/ApacheMonitor.exe
Removing third_party/apache-win32/bin/api-ms-win-core-console-l1-1-0.dll
Removing third_party/apache-win32/bin/api-ms-win-core-datetime-l1-1-0.dll
Removing third_party/apache-win32/bin/api-ms-win-core-debug-l1-1-0.dll
Removing third_party/apache-win32/bin/api-ms-win-core-errorhandling-l1-1-0.dll
Removing third_party/apache-win32/bin/api-ms-win-core-file-l1-1-0.dll
Removing third_party/apache-win32/bin/api-ms-win-core-file-l1-2-0.dll
Removing third_party/apache-win32/bin/api-ms-win-core-file-l2-1-0.dll
Removing third_party/apache-win32/bin/api-ms-win-core-handle-l1-1-0.dll
Removing third_party/apache-win32/bin/api-ms-win-core-heap-l1-1-0.dll
Removing third_party/apache-win32/bin/api-ms-win-core-interlocked-l1-1-0.dll
Removing third_party/apache-win32/bin/api-ms-win-core-libraryloader-l1-1-0.dll
Removing third_party/apache-win32/bin/api-ms-win-core-localization-l1-2-0.dll
Removing third_party/apache-win32/bin/api-ms-win-core-memory-l1-1-0.dll
Removing third_party/apache-win32/bin/api-ms-win-core-namedpipe-l1-1-0.dll
Removing third_party/apache-win32/bin/api-ms-win-core-processenvironment-l1-1-0.dll
Removing third_party/apache-win32/bin/api-ms-win-core-processthreads-l1-1-0.dll
Removing third_party/apache-win32/bin/api-ms-win-core-processthreads-l1-1-1.dll
Removing third_party/apache-win32/bin/api-ms-win-core-profile-l1-1-0.dll
Removing third_party/apache-win32/bin/api-ms-win-core-rtlsupport-l1-1-0.dll
Removing third_party/apache-win32/bin/api-ms-win-core-string-l1-1-0.dll
Removing third_party/apache-win32/bin/api-ms-win-core-synch-l1-1-0.dll
Removing third_party/apache-win32/bin/api-ms-win-core-synch-l1-2-0.dll
Removing third_party/apache-win32/bin/api-ms-win-core-sysinfo-l1-1-0.dll
Removing third_party/apache-win32/bin/api-ms-win-core-timezone-l1-1-0.dll
Removing third_party/apache-win32/bin/api-ms-win-core-util-l1-1-0.dll
Removing third_party/apache-win32/bin/api-ms-win-crt-conio-l1-1-0.dll
Removing third_party/apache-win32/bin/api-ms-win-crt-convert-l1-1-0.dll
Removing third_party/apache-win32/bin/api-ms-win-crt-environment-l1-1-0.dll
Removing third_party/apache-win32/bin/api-ms-win-crt-filesystem-l1-1-0.dll
Removing third_party/apache-win32/bin/api-ms-win-crt-heap-l1-1-0.dll
Removing third_party/apache-win32/bin/api-ms-win-crt-locale-l1-1-0.dll
Removing third_party/apache-win32/bin/api-ms-win-crt-math-l1-1-0.dll
Removing third_party/apache-win32/bin/api-ms-win-crt-multibyte-l1-1-0.dll
Removing third_party/apache-win32/bin/api-ms-win-crt-private-l1-1-0.dll
Removing third_party/apache-win32/bin/api-ms-win-crt-process-l1-1-0.dll
Removing third_party/apache-win32/bin/api-ms-win-crt-runtime-l1-1-0.dll
Removing third_party/apache-win32/bin/api-ms-win-crt-stdio-l1-1-0.dll
Removing third_party/apache-win32/bin/api-ms-win-crt-string-l1-1-0.dll
Removing third_party/apache-win32/bin/api-ms-win-crt-time-l1-1-0.dll
Removing third_party/apache-win32/bin/api-ms-win-crt-utility-l1-1-0.dll
Removing third_party/apache-win32/bin/httpd.exe
Removing third_party/apache-win32/bin/libapr-1.dll
Removing third_party/apache-win32/bin/libapriconv-1.dll
Removing third_party/apache-win32/bin/libaprutil-1.dll
Removing third_party/apache-win32/bin/libcrypto-1_1-x64.dll
Removing third_party/apache-win32/bin/libhttpd.dll
Removing third_party/apache-win32/bin/libssl-1_1-x64.dll
Removing third_party/apache-win32/bin/openssl.exe
Removing third_party/apache-win32/bin/pcre.dll
Removing third_party/apache-win32/bin/php7ts.dll
Removing third_party/apache-win32/bin/ucrtbase.dll
Removing third_party/apache-win32/bin/vcruntime140.dll
Removing third_party/apache-win32/bin/zlib1.dll
Removing third_party/apache-win32/modules/mod_access_compat.so
Removing third_party/apache-win32/modules/mod_alias.so
Removing third_party/apache-win32/modules/mod_asis.so
Removing third_party/apache-win32/modules/mod_authn_core.so
Removing third_party/apache-win32/modules/mod_authz_core.so
Removing third_party/apache-win32/modules/mod_authz_host.so
Removing third_party/apache-win32/modules/mod_autoindex.so
Removing third_party/apache-win32/modules/mod_cgi.so
Removing third_party/apache-win32/modules/mod_env.so
Removing third_party/apache-win32/modules/mod_headers.so
Removing third_party/apache-win32/modules/mod_log_config.so
Removing third_party/apache-win32/modules/mod_mime.so
Removing third_party/apache-win32/modules/mod_rewrite.so
Removing third_party/apache-win32/modules/mod_ssl.so
Removing third_party/apache-win32/modules/php7apache2_4.dll
Removing third_party/blink/renderer/bindings/scripts/__pycache__/
Removing third_party/blink/renderer/bindings/scripts/bind_gen/__pycache__/
Removing third_party/blink/renderer/bindings/scripts/web_idl/__pycache__/
Removing third_party/blink/renderer/build/scripts/__pycache__/
Removing third_party/blink/renderer/build/scripts/blinkbuild/__pycache__/
Removing third_party/blink/renderer/build/scripts/core/__pycache__/
Removing third_party/blink/renderer/build/scripts/core/css/__pycache__/
Removing third_party/blink/renderer/build/scripts/core/style/__pycache__/
Skipping repository third_party/devtools-frontend/src
Removing third_party/dom_distiller_js/protoc_plugins/util/__init__.pyc
Removing third_party/dom_distiller_js/protoc_plugins/util/plugin_protos.pyc
Removing third_party/dom_distiller_js/protoc_plugins/util/types.pyc
Removing third_party/dom_distiller_js/protoc_plugins/util/writer.pyc
Removing third_party/inspector_protocol/__pycache__/
Removing third_party/jinja2/__pycache__/
Removing third_party/llvm-build/
Removing third_party/mako/mako/__pycache__/
Removing third_party/mako/mako/ext/__pycache__/
Removing third_party/markupsafe/__pycache__/
Skipping repository third_party/mingw-w64/mingw/bin
Removing third_party/node/__pycache__/
Removing third_party/node/node_modules.tar.gz
Removing third_party/node/node_modules/
Removing third_party/node/win/node.exe
Removing third_party/opus/tests/resources/speech_mono_32_48kHz.pcm
Removing third_party/pefile_py3/__pycache__/
Removing third_party/pefile_py3/ordlookup/__pycache__/
Removing third_party/ply/__pycache__/
Removing third_party/protobuf/python/google/__init__.pyc
Removing third_party/protobuf/python/google/protobuf/__init__.pyc
Removing third_party/protobuf/python/google/protobuf/compiler/__init__.pyc
Removing third_party/protobuf/python/google/protobuf/compiler/plugin_pb2.pyc
Removing third_party/protobuf/python/google/protobuf/descriptor.pyc
Removing third_party/protobuf/python/google/protobuf/descriptor_database.pyc
Removing third_party/protobuf/python/google/protobuf/descriptor_pb2.pyc
Removing third_party/protobuf/python/google/protobuf/descriptor_pool.pyc
Removing third_party/protobuf/python/google/protobuf/internal/__init__.pyc
Removing third_party/protobuf/python/google/protobuf/internal/api_implementation.pyc
Removing third_party/protobuf/python/google/protobuf/internal/containers.pyc
Removing third_party/protobuf/python/google/protobuf/internal/decoder.pyc
Removing third_party/protobuf/python/google/protobuf/internal/encoder.pyc
Removing third_party/protobuf/python/google/protobuf/internal/enum_type_wrapper.pyc
Removing third_party/protobuf/python/google/protobuf/internal/extension_dict.pyc
Removing third_party/protobuf/python/google/protobuf/internal/message_listener.pyc
Removing third_party/protobuf/python/google/protobuf/internal/python_message.pyc
Removing third_party/protobuf/python/google/protobuf/internal/type_checkers.pyc
Removing third_party/protobuf/python/google/protobuf/internal/well_known_types.pyc
Removing third_party/protobuf/python/google/protobuf/internal/wire_format.pyc
Removing third_party/protobuf/python/google/protobuf/message.pyc
Removing third_party/protobuf/python/google/protobuf/message_factory.pyc
Removing third_party/protobuf/python/google/protobuf/reflection.pyc
Removing third_party/protobuf/python/google/protobuf/symbol_database.pyc
Removing third_party/protobuf/python/google/protobuf/text_encoding.pyc
Removing third_party/protobuf/python/google/protobuf/text_format.pyc
Removing third_party/protobuf/third_party/six/six.pyc
Removing third_party/pyjson5/src/json5/__pycache__/
Removing third_party/six/src/__pycache__/
Removing third_party/subresource-filter-ruleset/data/UnindexedRules
Removing third_party/test_fonts/test_fonts.tar.gz
Removing third_party/test_fonts/test_fonts/
Removing tools/diagnosis/__pycache__/
Removing tools/flags/__pycache__/
Removing tools/grit/grit/__pycache__/
Removing tools/grit/grit/extern/__pycache__/
Removing tools/grit/grit/format/__pycache__/
Removing tools/grit/grit/gather/__pycache__/
Removing tools/grit/grit/node/__pycache__/
Removing tools/grit/grit/tool/__pycache__/
Removing tools/grit/grit/tool/update_resource_ids/__pycache__/
Removing tools/idl_parser/__pycache__/
Removing tools/json_comment_eater/__pycache__/
Removing tools/json_schema_compiler/__pycache__/
Removing tools/json_to_struct/__pycache__/
Removing tools/luci-go/.versions/
Removing tools/luci-go/isolate.exe
Removing tools/luci-go/isolated.exe
Removing tools/luci-go/swarming.exe
Removing tools/metrics/common/__pycache__/
Removing tools/metrics/histograms/__pycache__/
Removing tools/metrics/ukm/__pycache__/
Removing tools/polymer/__pycache__/
Removing tools/resultdb/.versions/
Removing tools/resultdb/result_adapter.exe
Removing tools/skia_goldctl/
Removing tools/traffic_annotation/bin/win32/traffic_annotation_auditor.exe

현 커밋 기준 필요없는 파일을 지우기 위해
git clean -f(file)d(directory)x 하니까 untracked된 파일을 다 지우는데, 위 파일들 다 지워져도 괜찮은 거겠지..
->하나도 안 괜찮음. 대충 봐도 out 폴더 지워놓은.. 복구 방법 없다고 함, 빌드 다시 해야해..? 다신 함부로 건들지 말자 진짜
브랜치 삭제: git branch -d 브랜치 이름
브랜치 이동: git checkout 브랜치 이름
브랜치 생성 및 이동: git checkout -b 브랜치 이름

merge되지 않은 브랜치여도 상관없이 정말로 삭제하고 싶을때는 대문자
git branch -D 브랜치 이름

c:\chromium\src>git branch -d scrollbar
error: The branch 'scrollbar' is not fully merged.
If you are sure you want to delete it, run 'git branch -D scrollbar'.

c:\chromium\src>git branch -D scrollbar
Deleted branch scrollbar (was 13d49dc10492).

c:\chromium\src>git status
On branch main
Your branch is behind 'origin/main' by 6 commits, and can be fast-forwarded.
  (use "git pull" to update your local branch)

nothing to commit, working tree clean

c:\chromium\src>git branch -d orgin/main
error: The branch 'orgin/main' is not fully merged.
If you are sure you want to delete it, run 'git branch -D orgin/main'.

c:\chromium\src>git branch -D orgin/main
Deleted branch orgin/main (was 13d49dc10492).

이번 패치 시도는 버그가 고쳐지지 않았으니 실패.
고친 파일들 다시 reset함

profile
Department of Computer Science

0개의 댓글